Merged
Conversation
Added '*broadcast/' to .gitignore to ensure all broadcast directories are ignored
Added 'crytic-export/' to .gitignore to prevent Crytic analysis output files from being tracked in version control.
Renamed AddressesAndFees.sol to LibAddressesAndFees.sol and added _getAddressesAndFeesByChainId function to retrieve addresses and fee types based on chain ID. This improves modularity and chain support in the helper library.
Both CheckInFacet and FactoryFacet contracts now explicitly implement their respective interfaces (ICheckIn and IFactory). This change improves type safety and ensures interface compliance for these facets.
Introduces a new uint16 field, hostItFeeBps, to the MarketplaceStorage struct for storing fee basis points. Also reorders FeeType enum values for improved clarity.
Expanded TicketData, ExtraTicketData, and FullTicketData structs to include maxTicketsPerUser and isRefundable fields. Changed several time-related fields from uint40 to uint48 for increased range.
medusa.json is now ignored to prevent it from being tracked in version control.
Updated DeployHostItTickets.s.sol to use LibAddressesAndFees._getAddressesAndFeesByChainId for dynamic fee and address retrieval based on chain ID. Removed DeployHostItTicketsLisk.s.sol as its logic is now handled generically in the main deployment script.
Replaced the large ASCII art blocks in HostItTickets.sol and TicketProxy.sol with a more compact version. No functional code changes were made.
Changed baseURI function visibility from external to public and added comments to the paused function for clarity. These updates improve the contract's interface and documentation.
Refactored ticket creation logic for improved validation and error handling. Added new error TicketInitializationFailed, updated ExtraTicketData structure, and replaced Ticket with ITicket interface for better abstraction. Improved input checks and initialization process for ticket contracts.
Updated fee calculation to use dynamic basis points from storage, refactored functions to accept MarketplaceStorage as a parameter, and improved error handling with new error types. Added SafeCast usage, replaced FatalErrorTicketMismatch with TicketAccountingMismatch, and introduced CreateERC6551AccountFailed error for ERC6551 account creation failures.
Changed base contract from HelperContract to Test for improved test integration. Moved ticket creation and update helper functions for better code organization. Updated TicketData structures to include maxTicketsPerUser and isRefundable fields, enhancing ticket configuration for tests.
Replaces the test_adminTickets function to use uint64 instead of uint56 for ticket IDs and moves its position in the file. Adds commented-out fuzz test stubs for createTicket and updateTicket to prepare for future property-based testing.
Increased optimizer_runs to 999,999 and added fuzz section with runs set to 10,000 and max_test_rejects to 999,999 for improved testing configuration.
Updates the GitHub Actions workflow to install the nightly version of Foundry using the foundry-toolchain action. This ensures the workflow uses the latest nightly features and fixes.
Updated the calculateHostItFee function from pure to view to reflect its dependency on contract state. This ensures correct function visibility and usage.
Introduces the ability to set HostIt fee basis points via an admin function in LibMarketplace, updates initialization to set the fee, adds related error and event definitions, and adjusts the IMarketplace interface for fee calculation. This enhances fee management flexibility for the marketplace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.